==============================================================
Guild: Eric's Support Server
Channel: Still Need To Archive / tc-expression-parser-ce
Topic: Temp Channel
==============================================================

[29-Dec-20 06:42 AM] imnotstealth
alright


[29-Dec-20 06:42 AM] imnotstealth
so all I know about the bug is that some shaders when applied cos an npe


[29-Dec-20 06:42 AM] imnotstealth
gonna try the fix to see if I can fix it


[29-Dec-20 07:20 AM] imnotstealth
@mega12345mega what shader pack were you using?


[29-Dec-20 11:26 AM] mega12345mega
i was using 2 different ones since i program on a different computer than i play minecraft (long story)

I tested with Sildur's Enhanced Default v1.11 (which the first two fixes let this one run) and then after releasing the next update found out that it still couldn't run the other shader pack Sildur's Vibrant shaders v1.281 Medium, which I fixed with the
if (token == null) return null;

however this last fix is more of a work around than a solution; i don't know why there was a null token in the first place
the other two made sense though


[29-Dec-20 12:47 PM] mega12345mega
@Stealth I just found that Chocapic13_V9_High displays a black screen. i suspect this is due to the if null return null, but i'm not sure


[29-Dec-20 12:55 PM] imnotstealth
for me the seus shaders work, free and paid ones


[29-Dec-20 12:55 PM] imnotstealth
but when I try to use the DSL shader, game crashes


[29-Dec-20 01:11 PM] mega12345mega
interesting
BSL works for me, i can't find a download for DSL

whats the error log for DSL?


[29-Dec-20 01:11 PM] imnotstealth
its a npe


[29-Dec-20 01:12 PM] mega12345mega
yah, but more specific - like where did the error happen?
i assume this is after using the current fixes right? (fixing the constructors and function, plus adding the if null return null)


[29-Dec-20 01:12 PM] imnotstealth
gimme a sec lemme get the error


[29-Dec-20 01:14 PM] imnotstealth
my bad its bsl


[29-Dec-20 01:14 PM] imnotstealth
shaderpack


[29-Dec-20 01:14 PM] imnotstealth


{Attachments}
assets\message-7B679.txt


[29-Dec-20 01:19 PM] mega12345mega
oh yah, i think i fixed that one
its because some of the constructors are empty for some reason
here's all the current fixes i have
unless you already added them from earlier, then i'm not sure

{Attachments}
assets\shaderfix-8A127.txt


[29-Dec-20 01:26 PM] imnotstealth
yea i already added them in


[29-Dec-20 01:26 PM] mega12345mega
hummm


[29-Dec-20 01:28 PM] mega12345mega
on mine line 415 isn't inside the parse function


[29-Dec-20 01:28 PM] imnotstealth
wait no it is the bsl shader pack


[29-Dec-20 01:28 PM] imnotstealth
weirddddd


[29-Dec-20 01:28 PM] imnotstealth
it still crashes


[29-Dec-20 01:28 PM] mega12345mega
?


[29-Dec-20 01:29 PM] imnotstealth
game still crashes


[29-Dec-20 01:29 PM] mega12345mega
is it a different error?
what did you change?


[29-Dec-20 01:29 PM] imnotstealth
tried your fix with bsl


[29-Dec-20 01:30 PM] imnotstealth
works but its extremely gloomy


[29-Dec-20 01:30 PM] mega12345mega
thats probably in the shader settings
can you send a screenshot?


[29-Dec-20 01:32 PM] imnotstealth
yea gimme a sec


[29-Dec-20 01:32 PM] imnotstealth
pc crashed so I have to restart all my apps again


[29-Dec-20 01:36 PM] imnotstealth
*gloomy*

{Attachments}
assets\unknown-D7078.png


[29-Dec-20 01:37 PM] mega12345mega
i think thats normal for BSL - try it in a normal optifine installation


[29-Dec-20 01:37 PM] imnotstealth
yea


[29-Dec-20 01:38 PM] imnotstealth
but i might have found a fix


[29-Dec-20 01:38 PM] imnotstealth
more of a work around like you said


[29-Dec-20 01:39 PM] imnotstealth
you said you added if (token == null) return null;

{Attachments}
assets\unknown-33D84.png


[29-Dec-20 01:39 PM] imnotstealth
i tried going a bit further and adding if (tokens == null) return null;


[29-Dec-20 01:39 PM] imnotstealth
and now i tried every shader pack i have (around 9) and they all work


[29-Dec-20 01:40 PM] mega12345mega
hum do you have Chocapic13_V9?
it just shows a black screen for me
even without the if (tokens == null) return null; i haven't had a crash, but does it fix the black screen?


[29-Dec-20 01:41 PM] imnotstealth
i'll download it in a sec


[29-Dec-20 01:42 PM] mega12345mega
yah this is BSL shaders with normal optifine (not a custom client)
its still kinda gloomy

{Attachments}
assets\2020-12-29_13.42.02-75191.png


[29-Dec-20 01:43 PM] mega12345mega
especially if the sun goes behind a cloud


[29-Dec-20 01:43 PM] imnotstealth
yea


[29-Dec-20 01:43 PM] imnotstealth
also getting a black screen


[29-Dec-20 01:44 PM] imnotstealth
does it crash if we remove the null checks?


[29-Dec-20 01:45 PM] mega12345mega
not sure, ill test that
also i think the second if (tokens == null) return null; isn't relevant because the next if statement tests if tokens == null and handles it


[29-Dec-20 01:45 PM] imnotstealth
hmm


[29-Dec-20 01:48 PM] imnotstealth
you sure?


[29-Dec-20 01:48 PM] mega12345mega
ok so removing if (token == null) return null; does cause the client to crash when using the Chocapic13_V9 shaders


[29-Dec-20 01:48 PM] imnotstealth
alright


[29-Dec-20 01:48 PM] imnotstealth
since its checking for token not tokens


[29-Dec-20 01:49 PM] mega12345mega
do you have a pack where having the if (tokens == null) fixes it?


[29-Dec-20 01:49 PM] imnotstealth
i'll try them quickly


[29-Dec-20 01:58 PM] imnotstealth
tried looking into console when applying the chocapic shader


[29-Dec-20 01:59 PM] imnotstealth
a good amount is unknown function or missing argument


[29-Dec-20 01:59 PM] mega12345mega
that doesn't sound easy to fix


[29-Dec-20 01:59 PM] imnotstealth
its seems like its trying to reload everything a couple times

{Attachments}
assets\message-094A8.txt


[29-Dec-20 01:59 PM] imnotstealth
with no success


[29-Dec-20 01:59 PM] imnotstealth
so it says black


[29-Dec-20 02:00 PM] imnotstealth
thats what i'm thinking


[29-Dec-20 02:00 PM] mega12345mega
maybe it has to do with how some of the function names are changed to like func_abcd_0


[29-Dec-20 02:01 PM] imnotstealth
maybe


[29-Dec-20 02:01 PM] imnotstealth
i hope not though


[29-Dec-20 02:01 PM] imnotstealth
but some function names are


[29-Dec-20 02:01 PM] imnotstealth
sunPosX


[29-Dec-20 02:01 PM] imnotstealth
etc


[29-Dec-20 02:01 PM] imnotstealth
[22:56:58] [Client thread/WARN]: [Shaders] net.optifine.expr.ParseException: Missing arguments: MOD
[22:56:58] [Client thread/INFO]: [Shaders] Custom variable: normSunVec 
like this per example


[29-Dec-20 02:02 PM] imnotstealth
and they are custom vars so i don't think method obf is the problem


[29-Dec-20 02:02 PM] imnotstealth
what i'm thinking


[29-Dec-20 02:02 PM] imnotstealth
is maybe we are just running some old optifine


[29-Dec-20 02:02 PM] mega12345mega
from messing with the sildurs vibrant shaders i found that deleting the block.properies causes the back screen


[29-Dec-20 02:02 PM] imnotstealth
hmm


[29-Dec-20 02:02 PM] imnotstealth
i'll try updating optifine


[29-Dec-20 02:02 PM] imnotstealth
and see if that works


[29-Dec-20 02:03 PM] imnotstealth
nvm i'm on the latest version


[29-Dec-20 02:03 PM] mega12345mega
i think i have the newest version (1.8.9)
unless you have a way to load like 1.16


[29-Dec-20 02:03 PM] imnotstealth
i could try


[29-Dec-20 02:03 PM] imnotstealth
i mean i have 1.8.8


[29-Dec-20 02:04 PM] mega12345mega
what minecraft version are you using?
i found a tutorial to use mcp to get 1.8.9


[29-Dec-20 02:06 PM] imnotstealth
i got 1.8.9 and 1.8.8 working (with optifine)


[29-Dec-20 02:06 PM] imnotstealth
so i'm gonna try the shaders


[29-Dec-20 02:09 PM] imnotstealth
tried running chocapic on 1.8.8, got this in chat

{Attachments}
assets\unknown-BC84D.png


[29-Dec-20 02:09 PM] imnotstealth
also 1.8.8 doesn't have an ExpressionParser class


[29-Dec-20 02:10 PM] mega12345mega
theres a whole bunch of blocks not found like this one:
Block not found for name: minecraft:white_wall_banner

it seems like the shader is for a newer minecraft version, but optifine normally is somehow able to convert everything


[29-Dec-20 02:10 PM] imnotstealth
yea


[29-Dec-20 02:11 PM] mega12345mega
ooo i think i found something


[29-Dec-20 02:12 PM] imnotstealth
?


[29-Dec-20 02:12 PM] mega12345mega
this has a download for 1.8.9 specifically, and it works
https://minecraftio.com/chocapic13s-shaders-mod/


[29-Dec-20 02:12 PM] imnotstealth
oooooooo


[29-Dec-20 02:12 PM] imnotstealth
so we did fix the problem after all!


[29-Dec-20 02:13 PM] imnotstealth
at least for now


[29-Dec-20 02:13 PM] mega12345mega
its not perfect since the block overlay doesn't work, but that might just be due to the shader

{Attachments}
assets\2020-12-29_14.12.34-4CECE.png


[29-Dec-20 02:14 PM] mega12345mega
so i think that as long as someone doesn't try to load a shader for a newer version, it should work


[29-Dec-20 02:15 PM] imnotstealth
yea


[29-Dec-20 02:15 PM] imnotstealth
but the version you linked is v5


[29-Dec-20 02:15 PM] imnotstealth
what we tried before is v9


[29-Dec-20 02:17 PM] mega12345mega
i think that the shaders for older versions must not be getting updated, so you would have to figure out how to load newer packs if you wanted the newest version


[29-Dec-20 02:18 PM] imnotstealth
@_@


[29-Dec-20 02:18 PM] imnotstealth
screw that lmao


[29-Dec-20 02:18 PM] mega12345mega
yah


[29-Dec-20 02:18 PM] mega12345mega
so i think we have a solution right?


[29-Dec-20 02:19 PM] imnotstealth
i mean even this works so i think so yea

{Attachments}
assets\unknown-8C34C.png


[29-Dec-20 02:19 PM] imnotstealth
we prevented most crashes


[29-Dec-20 02:19 PM] imnotstealth
what i don't understand is that i have the paid seus shaders


[29-Dec-20 02:19 PM] imnotstealth
and the higher the number the later the version you need


[29-Dec-20 02:20 PM] imnotstealth
i'm on the highest version and it works


[29-Dec-20 02:21 PM] mega12345mega
i think that some shaders have "converters" built in maybe
this is inside the sildurs shaders and it looks like it is converting the block ids or something

{Attachments}
assets\block-DC104.properties


[29-Dec-20 02:21 PM] imnotstealth
taking about these btw

{Attachments}
assets\unknown-E83A9.png


[29-Dec-20 02:23 PM] imnotstealth
but thats their problem imo


[29-Dec-20 02:24 PM] mega12345mega
yah
if the client can run most shaders (like it can currently) then i think it is fine


[29-Dec-20 02:24 PM] imnotstealth
yea


[29-Dec-20 02:25 PM] mega12345mega
so i think we can have Eric add it to the common errors section right?


[29-Dec-20 02:25 PM] imnotstealth
yea


[29-Dec-20 02:25 PM] imnotstealth
i'd say so


[29-Dec-20 02:25 PM] imnotstealth
yo my boi @2Old4This


[29-Dec-20 02:25 PM] imnotstealth
we done here lmao


[29-Dec-20 02:25 PM] imnotstealth
we also have to provide the fix


[29-Dec-20 02:26 PM] mega12345mega (pinned)
i think this is everything

{Attachments}
assets\shaderfix-4F692.txt


[29-Dec-20 02:27 PM] imnotstealth
yep


[29-Dec-20 02:28 PM] mega12345mega
also unrelated, but has anyone created an automatic client exporter (like adding the libraries, assets, and stuff)? cause i have one that might be of use


[29-Dec-20 02:29 PM] ericgolde
Awesome sause, can you both send me any crash reports you experienced while coming up with this fix? Plan is to try to add those to the bots auto common error.


[29-Dec-20 02:29 PM] ericgolde
I will add that text document and both your names to #common-errors sometime today


[29-Dec-20 02:30 PM] ericgolde
Also, here is contributor rank for contributing to the server Mega12345Mega (Sorry stealth, you already have that rank :P)


[29-Dec-20 02:30 PM] imnotstealth
sure gimme a sec


[29-Dec-20 02:30 PM] imnotstealth
@_@


[29-Dec-20 02:30 PM] mega12345mega
there's like three different errors * 2 since it looks slightly different on startup and loading the shader


[29-Dec-20 02:30 PM] imnotstealth (pinned)


{Attachments}
assets\message-D44D2.txt


[29-Dec-20 02:30 PM] ericgolde
thats totally fine. Any crash reports no matter if they are the same is very helpful


[29-Dec-20 02:30 PM] imnotstealth
thats the most common one i get


[29-Dec-20 02:31 PM] ericgolde
I can set the bot up to identify mutiple kinds of crash reports etc


[29-Dec-20 02:31 PM] ericgolde
Pinned a message.


[29-Dec-20 02:31 PM] mega12345mega (pinned)
i think it might be easier to test for a null pointer Shaders.loadShaderPackProperties cause all of the errors come from that


[29-Dec-20 02:31 PM] ericgolde
Pinned a message.


[29-Dec-20 02:31 PM] ericgolde
Pinned a message.


[29-Dec-20 02:31 PM] ericgolde
If all of the errors extend from that, perfect


[29-Dec-20 02:31 PM] ericgolde
Just need to tell the bot the difference between a null pointer and a shader nullpointer


[29-Dec-20 02:32 PM] ericgolde
Is it all to do with ```net.optifine.expr.ExpressionParser``` or ```net.optifine.shaders.Shaders.loadShaderPackProperties```
?


[29-Dec-20 02:33 PM] mega12345mega
i think they all have the first one, i don't remember specifically, but they all have the second one


[29-Dec-20 02:33 PM] imnotstealth
yea they do


[29-Dec-20 02:34 PM] imnotstealth
the expression thing is the first thing you see in the crash log


[29-Dec-20 02:34 PM] mega12345mega
some of them start with FunctionType.parse


[29-Dec-20 04:30 PM] ericgolde


{Attachments}
assets\crash_report_test-B3834.txt


[29-Dec-20 04:30 PM] ESS - Utilities#2637
[Crash Report Identifier] Parsing crash data... This might take a moment.


[29-Dec-20 04:30 PM] ESS - Utilities#2637


{Embed}
✅ This error has been answered before
Looks like you are using Optifine for 1.8.9, and trying to use a Shaderpack.

Please download the attached document by Stealth, and mega12345mega. 

They both have spent some time trying to debug this issue, and write some instructions n how to fix it.
ESS - Utilities#2637


[29-Dec-20 04:30 PM] ESS - Utilities#2637


{Attachments}
assets\shader-fix-instructions-B408B.txt


[29-Dec-20 04:31 PM] ericgolde
If both of you could test it out by uploading all relivant crash reports and making sure it gives that same output, that would be fantastic


[29-Dec-20 04:31 PM] ericgolde
I am also happy to add a ,ce command if you think that is nessessarry


[29-Dec-20 05:05 PM] mega12345mega


{Attachments}
assets\crash-2020-12-28_19.30.07-client-B8456.txt


[29-Dec-20 05:05 PM] ESS - Utilities#2637
[Crash Report Identifier] Parsing crash data... This might take a moment.


[29-Dec-20 05:05 PM] ESS - Utilities#2637


{Embed}
✅ This error has been answered before
Looks like you are using Optifine for 1.8.9, and trying to use a Shaderpack.

Please download the attached document by Stealth, and mega12345mega. 

They both have spent some time trying to debug this issue, and write some instructions n how to fix it.
ESS - Utilities#2637


[29-Dec-20 05:05 PM] ESS - Utilities#2637


{Attachments}
assets\shader-fix-instructions-11888.txt


[29-Dec-20 05:05 PM] mega12345mega


{Attachments}
assets\crash-2020-12-28_19.38.45-client-94C36.txt


[29-Dec-20 05:05 PM] ESS - Utilities#2637
[Crash Report Identifier] Parsing crash data... This might take a moment.


[29-Dec-20 05:05 PM] ESS - Utilities#2637


{Embed}
✅ This error has been answered before
Looks like you are using Optifine for 1.8.9, and trying to use a Shaderpack.

Please download the attached document by Stealth, and mega12345mega. 

They both have spent some time trying to debug this issue, and write some instructions n how to fix it.
ESS - Utilities#2637


[29-Dec-20 05:05 PM] ESS - Utilities#2637


{Attachments}
assets\shader-fix-instructions-68B82.txt


[29-Dec-20 05:06 PM] mega12345mega


{Attachments}
assets\crash-2020-12-26_10.46.49-client-7D8FA.txt


[29-Dec-20 05:06 PM] ESS - Utilities#2637
[Crash Report Identifier] Parsing crash data... This might take a moment.


[29-Dec-20 05:06 PM] ESS - Utilities#2637


{Embed}
✅ This error has been answered before
Looks like you are using Optifine for 1.8.9, and trying to use a Shaderpack.

Please download the attached document by Stealth, and mega12345mega. 

They both have spent some time trying to debug this issue, and write some instructions n how to fix it.
ESS - Utilities#2637


[29-Dec-20 05:06 PM] ESS - Utilities#2637


{Attachments}
assets\shader-fix-instructions-F0347.txt


[29-Dec-20 05:08 PM] ericgolde
awesome sause, thank you both so much for helping with this! I am going to close this channel. If either of you come up with more fixes or need to update the file the bot sends, either make a pull request on Github, or just ping me with the new file


[29-Dec-20 05:54 PM] imnotstealth
Alright, was fun helping out


==============================================================
Exported 161 message(s)
==============================================================