Eric's Support Server - tc-expression-parser-ce

Eric's Support Server

Still Need To Archive / tc-expression-parser-ce

Temp Channel

alright

06:42

so all I know about the bug is that some shaders when applied cos an npe

06:42

gonna try the fix to see if I can fix it

@mega12345mega what shader pack were you using?

i was using 2 different ones since i program on a different computer than i play minecraft (long story) I tested with Sildur's Enhanced Default v1.11 (which the first two fixes let this one run) and then after releasing the next update found out that it still couldn't run the other shader pack Sildur's Vibrant shaders v1.281 Medium, which I fixed with the if (token == null) return null; however this last fix is more of a work around than a solution; i don't know why there was a null token in the first place the other two made sense though

@Stealth I just found that Chocapic13_V9_High displays a black screen. i suspect this is due to the if null return null, but i'm not sure

for me the seus shaders work, free and paid ones

12:55

but when I try to use the DSL shader, game crashes

interesting BSL works for me, i can't find a download for DSL whats the error log for DSL?

its a npe

yah, but more specific - like where did the error happen? i assume this is after using the current fixes right? (fixing the constructors and function, plus adding the if null return null)

gimme a sec lemme get the error

13:14

my bad its bsl

13:14

shaderpack

13:14

9.85 KB

oh yah, i think i fixed that one its because some of the constructors are empty for some reason here's all the current fixes i have unless you already added them from earlier, then i'm not sure

1.8 KB

yea i already added them in

hummm

13:28

on mine line 415 isn't inside the parse function

wait no it is the bsl shader pack

13:28

weirddddd

13:28

it still crashes

?

game still crashes

is it a different error? what did you change?

tried your fix with bsl

13:30

works but its extremely gloomy

thats probably in the shader settings can you send a screenshot?

yea gimme a sec

13:32

pc crashed so I have to restart all my apps again

13:36

gloomy

Image attachment

i think thats normal for BSL - try it in a normal optifine installation

yea

13:38

but i might have found a fix

13:38

more of a work around like you said

13:39

you said you added if (token == null) return null;

Image attachment

13:39

i tried going a bit further and adding if (tokens == null) return null;

13:39

and now i tried every shader pack i have (around 9) and they all work

hum do you have Chocapic13_V9? it just shows a black screen for me even without the if (tokens == null) return null; i haven't had a crash, but does it fix the black screen?

i'll download it in a sec

yah this is BSL shaders with normal optifine (not a custom client) its still kinda gloomy

Image attachment

13:43

especially if the sun goes behind a cloud

yea

13:43

also getting a black screen

13:44

does it crash if we remove the null checks?

not sure, ill test that also i think the second if (tokens == null) return null; isn't relevant because the next if statement tests if tokens == null and handles it

hmm

13:48

you sure?

ok so removing if (token == null) return null; does cause the client to crash when using the Chocapic13_V9 shaders

alright

13:48

since its checking for token not tokens (edited)

do you have a pack where having the if (tokens == null) fixes it?

i'll try them quickly

tried looking into console when applying the chocapic shader

13:59

a good amount is unknown function or missing argument

that doesn't sound easy to fix

its seems like its trying to reload everything a couple times

100.24 KB

13:59

with no success

13:59

so it says black

14:00

thats what i'm thinking

maybe it has to do with how some of the function names are changed to like func_abcd_0

maybe

14:01

i hope not though

14:01

but some function names are

14:01

sunPosX

14:01

etc

14:01

[22:56:58] [Client thread/WARN]: [Shaders] net.optifine.expr.ParseException: Missing arguments: MOD [22:56:58] [Client thread/INFO]: [Shaders] Custom variable: normSunVec like this per example

14:02

and they are custom vars so i don't think method obf is the problem

14:02

what i'm thinking

14:02

is maybe we are just running some old optifine

from messing with the sildurs vibrant shaders i found that deleting the block.properies causes the back screen

hmm

14:02

i'll try updating optifine

14:02

and see if that works

14:03

nvm i'm on the latest version

i think i have the newest version (1.8.9) unless you have a way to load like 1.16

i could try

14:03

i mean i have 1.8.8

what minecraft version are you using? i found a tutorial to use mcp to get 1.8.9

i got 1.8.9 and 1.8.8 working (with optifine) (edited)

14:06

so i'm gonna try the shaders

14:09

tried running chocapic on 1.8.8, got this in chat

Image attachment

14:09

also 1.8.8 doesn't have an ExpressionParser class (edited)

theres a whole bunch of blocks not found like this one: Block not found for name: minecraft:white_wall_banner it seems like the shader is for a newer minecraft version, but optifine normally is somehow able to convert everything

yea

ooo i think i found something

?

this has a download for 1.8.9 specifically, and it works https://minecraftio.com/chocapic13s-shaders-mod/

oooooooo

14:12

so we did fix the problem after all!

14:13

at least for now

its not perfect since the block overlay doesn't work, but that might just be due to the shader

Image attachment

14:14

so i think that as long as someone doesn't try to load a shader for a newer version, it should work

yea

14:15

but the version you linked is v5

14:15

what we tried before is v9

i think that the shaders for older versions must not be getting updated, so you would have to figure out how to load newer packs if you wanted the newest version

@_@

14:18

screw that lmao

yah

14:18

so i think we have a solution right?

i mean even this works so i think so yea

Image attachment

14:19

we prevented most crashes

14:19

what i don't understand is that i have the paid seus shaders

14:19

and the higher the number the later the version you need (edited)

14:20

i'm on the highest version and it works

i think that some shaders have "converters" built in maybe this is inside the sildurs shaders and it looks like it is converting the block ids or something

block.properties

3.53 KB

taking about these btw

Image attachment

14:23

but thats their problem imo

yah if the client can run most shaders (like it can currently) then i think it is fine

yea

so i think we can have Eric add it to the common errors section right?

yea

14:25

i'd say so

14:25

yo my boi @2Old4This

14:25

we done here lmao

14:25

we also have to provide the fix

i think this is everything

1.8 KB

yep

also unrelated, but has anyone created an automatic client exporter (like adding the libraries, assets, and stuff)? cause i have one that might be of use

Awesome sause, can you both send me any crash reports you experienced while coming up with this fix? Plan is to try to add those to the bots auto common error.

14:29

I will add that text document and both your names to #common-errors sometime today

14:30

Also, here is contributor rank for contributing to the server Mega12345Mega (Sorry stealth, you already have that rank :P)

sure gimme a sec

14:30

@_@

there's like three different errors * 2 since it looks slightly different on startup and loading the shader

3.9 KB

thats totally fine. Any crash reports no matter if they are the same is very helpful

thats the most common one i get

I can set the bot up to identify mutiple kinds of crash reports etc

2Old4This pinned a message to this channel. 29-Dec-20 02:31 PM

i think it might be easier to test for a null pointer Shaders.loadShaderPackProperties cause all of the errors come from that

2Old4This pinned a message to this channel. 29-Dec-20 02:31 PM

2Old4This pinned a message to this channel. 29-Dec-20 02:31 PM

If all of the errors extend from that, perfect

14:31

Just need to tell the bot the difference between a null pointer and a shader nullpointer (edited)

14:32

Is it all to do with net.optifine.expr.ExpressionParser or net.optifine.shaders.Shaders.loadShaderPackProperties ? (edited)

i think they all have the first one, i don't remember specifically, but they all have the second one

yea they do

14:34

the expression thing is the first thing you see in the crash log

some of them start with FunctionType.parse

crash_report_test.txt

3.97 KB

[Crash Report Identifier] Parsing crash data... This might take a moment.

16:30

✅ This error has been answered before

Looks like you are using Optifine for 1.8.9, and trying to use a Shaderpack. Please download the attached document by Stealth, and mega12345mega. They both have spent some time trying to debug this issue, and write some instructions n how to fix it.

16:30

shader-fix-instructions.txt

1.84 KB

If both of you could test it out by uploading all relivant crash reports and making sure it gives that same output, that would be fantastic

16:31

I am also happy to add a ,ce command if you think that is nessessarry

crash-2020-12-28_19.30.07-client.txt

10.18 KB

[Crash Report Identifier] Parsing crash data... This might take a moment.

17:05

✅ This error has been answered before

Looks like you are using Optifine for 1.8.9, and trying to use a Shaderpack. Please download the attached document by Stealth, and mega12345mega. They both have spent some time trying to debug this issue, and write some instructions n how to fix it.

17:05

shader-fix-instructions.txt

1.84 KB

crash-2020-12-28_19.38.45-client.txt

4.57 KB

[Crash Report Identifier] Parsing crash data... This might take a moment.

17:05

✅ This error has been answered before

Looks like you are using Optifine for 1.8.9, and trying to use a Shaderpack. Please download the attached document by Stealth, and mega12345mega. They both have spent some time trying to debug this issue, and write some instructions n how to fix it.

17:05

shader-fix-instructions.txt

1.84 KB

crash-2020-12-26_10.46.49-client.txt

4.58 KB

[Crash Report Identifier] Parsing crash data... This might take a moment.

17:06

✅ This error has been answered before

Looks like you are using Optifine for 1.8.9, and trying to use a Shaderpack. Please download the attached document by Stealth, and mega12345mega. They both have spent some time trying to debug this issue, and write some instructions n how to fix it.

17:06

shader-fix-instructions.txt

1.84 KB

awesome sause, thank you both so much for helping with this! I am going to close this channel. If either of you come up with more fixes or need to update the file the bot sends, either make a pull request on Github, or just ping me with the new file (edited)

Alright, was fun helping out

Exported 161 message(s)